lkml.org 
[lkml]   [2018]   [Jan]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [V4, 01/11] Documentation: Add license-rules.rst to describe how to properly identify file licenses
On Fri, Jan 05, 2018 at 02:05:26PM +0100, Alexandre Belloni wrote:
> Hi,
>
> I'm definitively late to the party but...
>
> On 17/11/2017 at 11:00:33 +0100, Thomas Gleixner wrote:
> > +2. Style:
> > +
> > + The SPDX license identifier is added in form of a comment. The comment
> > + style depends on the file type::
> > +
> > + C source: // SPDX-License-Identifier: <SPDX License Expression>
> > + C header: /* SPDX-License-Identifier: <SPDX License Expression> */
> > + ASM: /* SPDX-License-Identifier: <SPDX License Expression> */
> > + scripts: # SPDX-License-Identifier: <SPDX License Expression>
> > + .rst: .. SPDX-License-Identifier: <SPDX License Expression>
> > + .dts{i}: // SPDX-License-Identifier: <SPDX License Expression>
>
> dtc doesn't handle // comments. This works in the kernel tree because
> dts files are preprocessed by CPP. But this doesn't work when using dtc
> directly (most likely when compiling DT overlays). So, the choice is
> between making dtc handle // comments or changing the documentation.

Does all the CPP macros that we use for things like GPIOs work when you
avoid CPP?

What I'm saying is that preprocessing the DTS in the kernel tree with
CPP appears to be a necessity, and doing so will deal with the C++
comments.

--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up
According to speedtest.net: 8.21Mbps down 510kbps up

\
 
 \ /
  Last update: 2018-01-05 19:56    [W:0.202 / U:1.528 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site