[lkml]   [2018]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] platform/x86: dell-laptop: Guard SMBIOS calls with a mutex
On Tue, Jan 30, 2018 at 5:35 PM,  <> wrote:

>> > dell_set_arguments(0x2, 0, 0, 0);
>> > ret = dell_send_request(CLASS_INFO, SELECT_RFKILL);
>> Hi! I'm looking at this code, and do we need shared global buffer with
>> mutex protection at all? Is not buffer allocated on stack enough?
> Oh you mean rather than create buffer mutex to just remove global
> buffer and allocate in each function? That seems like a workable
> approach to me too.
> I'm fine with either way.
> Andy or Darren, what's your preference in this area?

It reminds me USB stuff where buffer for transfer is allocated on heap
before performing communication.
So, it looks similar to some extent and I have no objection on that
kind of approach.

With Best Regards,
Andy Shevchenko

 \ /
  Last update: 2018-01-30 16:40    [W:0.036 / U:15.652 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site