lkml.org 
[lkml]   [2018]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: Compilation error report for: drivers/firmware/q com scm.c:469:47: error: passing argument 3 of ‘dma alloc coherent’ from incompatible pointer type
On Tue, Jan 30, 2018 at 3:00 PM, Benjamin Gaignard
<benjamin.gaignard@linaro.org> wrote:
> 2018-01-30 14:25 GMT+01:00 Arnd Bergmann <arnd@arndb.de>:
>> On Tue, Jan 30, 2018 at 11:11 AM, Benjamin GAIGNARD
>> <benjamin.gaignard@st.com> wrote:
>>>
>>> On 01/12/2018 05:11 PM, Arnaud Pouliquen wrote:
>>>> Hello Andy,David,
>>> + Arnd
>>>
>>> I have the same issue on drm-misc-next.
>>> Does Arnaud's fix make sense or should we update/change the way of how
>>> we compile the kernel ?
>>
>> We've hit a couple of bugs with qcom drivers confusing physical addresses
>> and DMA addresses in the past, usually the drivers were buggy in
>> some form, and tried to use dma_alloc_coherent() to get a buffer
>> that gets passed into a firmware interface taking a physical address,
>> which is of course completely wrong.
>>
>>>> diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c
>>>> index af4c752..8dfbe61 100644
>>>> --- a/drivers/firmware/qcom_scm.c
>>>> +++ b/drivers/firmware/qcom_scm.c
>>>> @@ -448,7 +448,7 @@ int qcom_scm_assign_mem(phys_addr_t mem_addr, size_t
>>>> mem_sz,
>>>> struct qcom_scm_mem_map_info *mem_to_map;
>>>> phys_addr_t mem_to_map_phys;
>>>> phys_addr_t dest_phys;
>>>> - phys_addr_t ptr_phys;
>>>> + dma_addr_t ptr_phys;
>>>> size_t mem_to_map_sz;
>>>> size_t dest_sz;
>>>> size_t src_sz;
>>
>> This would be bad: you can basically never have a 'dma_addr_t ptr_phys': it can
>> be exactly one of 'dma address', 'physical address' or a pointer,
>> this claims that the
>> struct member is all three of them.
>>
>> The proper fix here is to stop using dma_alloc_coherent.
>
> Okay but that doesn't explain why we are the only ones to get an issue
> while the parameter
> doesn't match function prototype

For almost all configurations, dma_addr_t and phys_addr_t are the
same width, and gcc treats them as compatible.

I usually get the warning during randconfig builds, but you seem to
have started with a configuration like this.

Arnd

\
 
 \ /
  Last update: 2018-01-30 15:18    [W:0.085 / U:4.384 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site