lkml.org 
[lkml]   [2018]   [Jan]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v19 03/10] video: backlight: Add of_find_backlight helper in backlight.c
From
Date
On 01/29/2018 01:11 AM, Lee Jones wrote:
> On Fri, 26 Jan 2018, Randy Dunlap wrote:
>
>> On 01/26/2018 01:48 AM, Lee Jones wrote:
>>> On Wed, 24 Jan 2018, Meghana Madhyastha wrote:
>>>
>>>> Add of_find_backlight, a helper function which is a generic version
>>>> of tinydrm_of_find_backlight that can be used by other drivers to avoid
>>>> repetition of code and simplify things.
>>>>
>>>> Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
>>>> Reviewed-by: Noralf Trønnes <noralf@tronnes.org>
>>>> Reviewed-by: Sean Paul<seanpaul@chromium.org>
>>>> Signed-off-by: Meghana Madhyastha <meghana.madhyastha@gmail.com>
>>>
>>> Nit: These should be in chronological order.
>>
>> Where does that tidbit of information come from?
>> I have never heard or read that.
>
> Not sure it is documented anywhere. It appeared to be the widely
> used, most sensible approach, so I adopted it a few years ago.
>
> This method provides us with information which would otherwise be
> absent; including description of the patch submission/acceptance path
> and an idea of who did what, when.
>
> For example:
>
> Original Author sign-off
> Original Co-author sign-off
> [Additional contributions: rebase, API changes, fix-ups]
> Re-worker's sign-off
> Tester's tested-by
> Reviewer's acked-by/reviewed-by
> Level-2 Maintainer sign-off
> Level-1 Maintainer sign-off
>
> Are you aware of a more functional/practical/useful method?

No, I'm not.

Do you do anything else with this chronological order? E.g., do you verify
that someone actually did Ack or Test or Review a patch?

Sean: that dim tool looks interesting. I'll check it out.

thanks,
--
~Randy

\
 
 \ /
  Last update: 2018-01-30 03:31    [W:0.105 / U:0.388 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site