lkml.org 
[lkml]   [2018]   [Jan]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 30/71] net: igmp: fix source address check for IGMPv3 reports
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Felix Fietkau <nbd@nbd.name>


    [ Upstream commit ad23b750933ea7bf962678972a286c78a8fa36aa ]

    Commit "net: igmp: Use correct source address on IGMPv3 reports"
    introduced a check to validate the source address of locally generated
    IGMPv3 packets.
    Instead of checking the local interface address directly, it uses
    inet_ifa_match(fl4->saddr, ifa), which checks if the address is on the
    local subnet (or equal to the point-to-point address if used).

    This breaks for point-to-point interfaces, so check against
    ifa->ifa_local directly.

    Cc: Kevin Cernekee <cernekee@chromium.org>
    Fixes: a46182b00290 ("net: igmp: Use correct source address on IGMPv3 reports")
    Reported-by: Sebastian Gottschall <s.gottschall@dd-wrt.com>
    Signed-off-by: Felix Fietkau <nbd@nbd.name>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    net/ipv4/igmp.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/net/ipv4/igmp.c
    +++ b/net/ipv4/igmp.c
    @@ -332,7 +332,7 @@ static __be32 igmpv3_get_srcaddr(struct
    return htonl(INADDR_ANY);

    for_ifa(in_dev) {
    - if (inet_ifa_match(fl4->saddr, ifa))
    + if (fl4->saddr == ifa->ifa_local)
    return fl4->saddr;
    } endfor_ifa(in_dev);


    \
     
     \ /
      Last update: 2018-01-29 21:20    [W:4.614 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site