lkml.org 
[lkml]   [2018]   [Jan]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 1/2 v2] tpm: cmd_ready command can be issued only after granting locality
Date

> On Sun, Jan 28, 2018 at 09:17:53PM +0000, Winkler, Tomas wrote:
>
> > > I think if a driver can fail reliquish then it needs some kind of
> > > strategy to recover.
>
> > Maybe some driver can and some not, but if it doesn't succeed it
> > should return an error.
>
> But you can't just leave the driver in some inconsistent state..
>
> Every time I've audited something to do with 'add error codes to
> destroy/free/release' I find driver design issues..

I'm sure of it, but from this particular point the driver itself is stateless,
it's just reading HW state via registers. It's not going through driver state changes.

> > > Suggest trying the reliquish again on every next request until
> > > success, otherwise fail request locality, potentially permanently.
> >
> > This is something I rather prevent because it leaves the HW in kind of
> > undefined state ( and we should probably work on that a bit more later).
> > As far as I've debugged the flow now, the driver just fails, and the
> > error goes up user space caller or the internal flow is stopped.
>
> But tranmist_command will be called again - then what does the driver do?
> The driver needs an answer for that..
It will just fail again
>
> If you don't want to retry then I'd rather see request_locality permanently
> fail then adding a return code to release.

What do you mean exactly mean by permanently fail,
My current assumption is that it will fail permanently because the HW is not responsive
Or indicate error on any subsequent command, unless the hw recover somehow.
Currently I'm not aware of any possibility to reset the device except rebooting the system.


Thanks
Tomas

\
 
 \ /
  Last update: 2018-01-29 20:42    [W:0.480 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site