lkml.org 
[lkml]   [2018]   [Jan]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 1/2] perf stat: Add support to print counts for fixed times
On Fri, Jan 26, 2018 at 10:06:56AM +0100, ufo19890607 wrote:

SNIP

> @@ -1891,6 +1902,8 @@ static const struct option stat_options[] = {
> "command to run after to the measured command"),
> OPT_UINTEGER('I', "interval-print", &stat_config.interval,
> "print counts at regular interval in ms (>= 10)"),
> + OPT_INTEGER(0, "interval-count", &stat_config.times,
> + "print counts for fixed number of times"),
> OPT_SET_UINT(0, "per-socket", &stat_config.aggr_mode,
> "aggregate counts per processor socket", AGGR_SOCKET),
> OPT_SET_UINT(0, "per-core", &stat_config.aggr_mode,
> @@ -2689,6 +2702,7 @@ int cmd_stat(int argc, const char **argv)
> const char *mode;
> FILE *output = stderr;
> unsigned int interval;
> + int times;
> const char * const stat_subcommands[] = { "record", "report" };
>
> setlocale(LC_ALL, "");
> @@ -2719,6 +2733,7 @@ int cmd_stat(int argc, const char **argv)
> return __cmd_report(argc, argv);
>
> interval = stat_config.interval;
> + times = stat_config.times;
>
> /*
> * For record command the -o is already taken care of.
> @@ -2870,6 +2885,15 @@ int cmd_stat(int argc, const char **argv)
> "The overhead percentage could be high in some cases. "
> "Please proceed with caution.\n");
> }
> + if (times && interval)
> + interval_count = true;
> + else if (times && !interval) {

you can use stat_config.times in here, no need for 'times' copy

jirka

> + pr_err("interval-count option should be used together with "
> + "interval-print.\n");
> + parse_options_usage(stat_usage, stat_options, "interval-count", 0);
> + parse_options_usage(stat_usage, stat_options, "I", 1);
> + goto out;
> + }
>
> if (perf_evlist__alloc_stats(evsel_list, interval))
> goto out;
> diff --git a/tools/perf/util/stat.h b/tools/perf/util/stat.h
> index dbc6f7134f61..b2f8a347d358 100644
> --- a/tools/perf/util/stat.h
> +++ b/tools/perf/util/stat.h
> @@ -90,6 +90,7 @@ struct perf_stat_config {
> bool scale;
> FILE *output;
> unsigned int interval;
> + int times;
> struct runtime_stat *stats;
> int stats_num;
> };
> --
> 2.14.1
>

\
 
 \ /
  Last update: 2018-01-29 08:30    [W:0.044 / U:0.608 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site