lkml.org 
[lkml]   [2018]   [Jan]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] kbuild: clang: Disable -Wunused-const-variable warnings
On 2018-01-28 08:22, Segher Boessenkool wrote:
> On Fri, Jan 26, 2018 at 04:59:46PM -0800, Prasad Sodagudi wrote:
>> Disable -Wunused-const-variable warnings instead of
>> disabling -Wunused-variable warnings, So that in both
>> clang and GCC -Wunused-const-variable gets disabled.
>
> Why would you disable -Wunused-const-variable on GCC? You do not
> explain why.

Hi Segher,

Please check below discussion with Greg and Masahiro about
"unused-variable".
https://lkml.org/lkml/2017/12/18/697


Please check this link, "unused-const-variable" warning is already
disabled for GCC.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Makefile?h=v4.15#n719
Below commit is disabling the "unused-const-variable" for GCC.
commit - c9c6837d39311b0c - "kbuild: move -Wunused-const-variable to
W=1 warning level"

Currently "unused-variable" warnings are disabled for clang and not for
the gcc. Disabling of
"unused-variable" warning also disables "unused-const-variable" warning.
To match same settings
between clang and gcc, disabling "unused-const-variable" warnings for
clang as well.
So with this patch, keeping the same settings for GCC and CLANG with
respect to "unused-const-variable".

-Thanks, Prasad

>
>
> Segher

--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
Forum,
Linux Foundation Collaborative Project

\
 
 \ /
  Last update: 2018-01-29 17:35    [W:0.123 / U:2.988 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site