lkml.org 
[lkml]   [2018]   [Jan]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] ARM: dts: exynos: Fix missing missing reg warning for syscon restart nodes
On Tue, Jan 16, 2018 at 10:31:28PM +0100, Krzysztof Kozlowski wrote:
> Fix DTC warnings like:
>
> arch/arm/boot/dts/exynos4412-trats2.dtb: Warning (simple_bus_reg):
> Node /soc/syscon-poweroff missing or empty reg/ranges property
> arch/arm/boot/dts/exynos4412-trats2.dtb: Warning (simple_bus_reg):
> Node /soc/syscon-reboot missing or empty reg/ranges property
>
> by moving the syscon poweroff and restart nodes into the PMU (Power
> Management Unit) node. The PMU node is the actual block responsible for
> power management, including typical Exynos on/off/restart procedures.
> Therefore the syscon poweroff and restart nodes logically belong to it.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>
> ---
>
> Tested on Exynos5420 and Exynos4412. Other tests are welcomed.
> ---
> .../devicetree/bindings/arm/samsung/pmu.txt | 4 +++-
> arch/arm/boot/dts/exynos-syscon-restart.dtsi | 28 ++++++++++------------
> arch/arm/boot/dts/exynos3250.dtsi | 4 ++--
> arch/arm/boot/dts/exynos4.dtsi | 5 ++--
> arch/arm/boot/dts/exynos4412.dtsi | 2 +-
> arch/arm/boot/dts/exynos5.dtsi | 1 -
> arch/arm/boot/dts/exynos5250.dtsi | 3 ++-
> arch/arm/boot/dts/exynos5410.dtsi | 3 ++-
> arch/arm/boot/dts/exynos5420.dtsi | 3 ++-
> 9 files changed, 27 insertions(+), 26 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/samsung/pmu.txt b/Documentation/devicetree/bindings/arm/samsung/pmu.txt
> index 779f5614bcee..405646655ec7 100644
> --- a/Documentation/devicetree/bindings/arm/samsung/pmu.txt
> +++ b/Documentation/devicetree/bindings/arm/samsung/pmu.txt
> @@ -12,6 +12,8 @@ Properties:
> - "samsung,exynos5433-pmu" - for Exynos5433 SoC.
> - "samsung,exynos7-pmu" - for Exynos7 SoC.
> second value must be always "syscon".
> + If PMU contains optional syscon-poweroff or syscon-restart nodes,
> + then third value must be "simple-mfd".

I don't think this is right. simple-mfd is only for cases where the
parent has no setup that the child nodes are dependent on. You need the
regmap setup by the parent before the child can be enumerated. The
correct thing to do here is add an of_platform_default_populate() call.

Rob

\
 
 \ /
  Last update: 2018-01-29 17:27    [W:0.055 / U:0.884 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site