lkml.org 
[lkml]   [2018]   [Jan]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 01/16] dt-bindings: update the Allwinner GPADC device tree binding for H3 & A83T
From
Date
>> +Example for A33:
>> ths: ths@1c25000 {
>> compatible = "allwinner,sun8i-a33-ths";
>> reg = <0x01c25000 0x100>;
>> @@ -17,6 +40,27 @@ Example:
>> #io-channel-cells = <0>;
>> };
>>
>> +Example for H3:
>> + ths: thermal-sensor@1c25000 {
>> + compatible = "allwinner,sun8i-h3-ths";
>> + reg = <0x01c25000 0x400>;
>> + clocks = <&ccu CLK_BUS_THS>, <&ccu CLK_THS>;
>> + clock-names = "bus", "mod";
>> + resets = <&ccu RST_BUS_THS>;
>> + interrupts = <GIC_SPI 31 IRQ_TYPE_LEVEL_HIGH>;
>> + #thermal-sensor-cells = <0>;
>> + #io-channel-cells = <0>;
>> + };
>> +
>> +Example for A83T:
>> + ths: thermal-sensor@1f04000 {
>> + compatible = "allwinner,sun8i-a83t-ths";
>> + reg = <0x01f04000 0x100>;
>> + interrupts = <GIC_SPI 41 IRQ_TYPE_LEVEL_HIGH>;
>> + #thermal-sensor-cells = <1>;
>> + #io-channel-cells = <0>;
>> + };
>> +
>
> I'm wondering if this is actually needed. We've used this convoluted
> constructs to be compatible with the old driver, but I'm not sure this
> is actually worth it now, and this is causing several issues, among
> which:
> - We need to have a bunch of quirks to handle all the DT cases.
> - We need to have an MFD, which isn't really optimal
>
> So I'd rather introduce a new compatible for the old SoCs, keep the
> old driver around, and simplify a lot that driver code that will ease
> further developments. And we can also get rid of the MFD in the
> process. I discussed it with Quentin, and he was ok with it, what do
> you think?
>
> (and that would involve creating a new file for the bindings you
> introduce here).
>
> Maxime
>

I think this is a good idea, and the desired way to rework the driver.

To sum up what we talked on IRC:

This will end up in removing the MFD driver and moving the interrupt
handling into the iio driver. At the end this will also simplify the IRQ
part.

Philipp

\
 
 \ /
  Last update: 2018-01-29 13:31    [W:0.068 / U:5.860 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site