Messages in this thread |  | | From | Ard Biesheuvel <> | Date | Mon, 29 Jan 2018 10:51:26 +0000 | Subject | Re: [PATCH V4 0/3] Use mm_struct and switch_mm() instead of manually |
| |
On 26 January 2018 at 21:16, Matt Fleming <matt@codeblueprint.co.uk> wrote: > On Thu, 18 Jan, at 01:01:04PM, Sai Praneeth Prakhya wrote: >> From: Sai Praneeth <sai.praneeth.prakhya@intel.com> >> >> Presently, in x86, to invoke any efi function like >> efi_set_virtual_address_map() or any efi_runtime_service() the code path >> typically involves read_cr3() (save previous pgd), write_cr3() >> (write efi_pgd) and calling efi function. Likewise after returning from >> efi function the code path typically involves read_cr3() (save efi_pgd), >> write_cr3() (write previous pgd). We do this couple of times in efi >> subsystem of Linux kernel, instead we can use helper function >> efi_switch_mm() to do this. This improves readability and maintainability. >> Also, instead of maintaining a separate struct "efi_scratch" to store/restore >> efi_pgd, we can use mm_struct to do this. > > FWIW this series looks OK to me. > > Reviewed-by: Matt Fleming <matt@codeblueprint.co.uk>
Thanks Matt
I know the x86 guys have been rather busy lately, so I will give them some more time to respond. If there are no objections raised, I will queue it for v4.17 in a couple of weeks.
|  |