Messages in this thread Patch in this message |  | | Subject | [PATCH 2/2] Input: max7359_keypad: Improve a size determination in max7359_probe() | From | SF Markus Elfring <> | Date | Sat, 27 Jan 2018 13:15:06 +0100 |
| |
From: Markus Elfring <elfring@users.sourceforge.net> Date: Sat, 27 Jan 2018 13:00:10 +0100
Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/input/keyboard/max7359_keypad.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/input/keyboard/max7359_keypad.c b/drivers/input/keyboard/max7359_keypad.c index ba6a670a769e..7791250b4667 100644 --- a/drivers/input/keyboard/max7359_keypad.c +++ b/drivers/input/keyboard/max7359_keypad.c @@ -181,9 +181,7 @@ static int max7359_probe(struct i2c_client *client, } dev_dbg(&client->dev, "keys FIFO is 0x%02x\n", ret); - - keypad = devm_kzalloc(&client->dev, sizeof(struct max7359_keypad), - GFP_KERNEL); + keypad = devm_kzalloc(&client->dev, sizeof(*keypad), GFP_KERNEL); if (!keypad) return -ENOMEM; -- 2.16.1
|  |