lkml.org 
[lkml]   [2018]   [Jan]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v5 1/7] x86/cpufeatures: Add CPUID_7_EDX CPUID leaf
    Date
    This is a pure feature bits leaf. We have two AVX512 feature bits in it
    already which were handled as scattered bits, and I'm about to add three
    more from this leaf for speculation control features.

    Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
    Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Reviewed-by: Borislav Petkov <bp@suse.de>
    ---
    arch/x86/include/asm/cpufeature.h | 7 +++++--
    arch/x86/include/asm/cpufeatures.h | 8 +++++---
    arch/x86/include/asm/disabled-features.h | 3 ++-
    arch/x86/include/asm/required-features.h | 3 ++-
    arch/x86/kernel/cpu/common.c | 1 +
    arch/x86/kernel/cpu/scattered.c | 2 --
    6 files changed, 15 insertions(+), 9 deletions(-)

    diff --git a/arch/x86/include/asm/cpufeature.h b/arch/x86/include/asm/cpufeature.h
    index ea9a7dd..70eddb3 100644
    --- a/arch/x86/include/asm/cpufeature.h
    +++ b/arch/x86/include/asm/cpufeature.h
    @@ -29,6 +29,7 @@ enum cpuid_leafs
    CPUID_8000_000A_EDX,
    CPUID_7_ECX,
    CPUID_8000_0007_EBX,
    + CPUID_7_EDX,
    };

    #ifdef CONFIG_X86_FEATURE_NAMES
    @@ -79,8 +80,9 @@ extern const char * const x86_bug_flags[NBUGINTS*32];
    CHECK_BIT_IN_MASK_WORD(REQUIRED_MASK, 15, feature_bit) || \
    CHECK_BIT_IN_MASK_WORD(REQUIRED_MASK, 16, feature_bit) || \
    CHECK_BIT_IN_MASK_WORD(REQUIRED_MASK, 17, feature_bit) || \
    + CHECK_BIT_IN_MASK_WORD(REQUIRED_MASK, 18, feature_bit) || \
    REQUIRED_MASK_CHECK || \
    - BUILD_BUG_ON_ZERO(NCAPINTS != 18))
    + BUILD_BUG_ON_ZERO(NCAPINTS != 19))

    #define DISABLED_MASK_BIT_SET(feature_bit) \
    ( CHECK_BIT_IN_MASK_WORD(DISABLED_MASK, 0, feature_bit) || \
    @@ -101,8 +103,9 @@ extern const char * const x86_bug_flags[NBUGINTS*32];
    CHECK_BIT_IN_MASK_WORD(DISABLED_MASK, 15, feature_bit) || \
    CHECK_BIT_IN_MASK_WORD(DISABLED_MASK, 16, feature_bit) || \
    CHECK_BIT_IN_MASK_WORD(DISABLED_MASK, 17, feature_bit) || \
    + CHECK_BIT_IN_MASK_WORD(DISABLED_MASK, 18, feature_bit) || \
    DISABLED_MASK_CHECK || \
    - BUILD_BUG_ON_ZERO(NCAPINTS != 18))
    + BUILD_BUG_ON_ZERO(NCAPINTS != 19))

    #define cpu_has(c, bit) \
    (__builtin_constant_p(bit) && REQUIRED_MASK_BIT_SET(bit) ? 1 : \
    diff --git a/arch/x86/include/asm/cpufeatures.h b/arch/x86/include/asm/cpufeatures.h
    index 25b9375..7b25cf3 100644
    --- a/arch/x86/include/asm/cpufeatures.h
    +++ b/arch/x86/include/asm/cpufeatures.h
    @@ -13,7 +13,7 @@
    /*
    * Defines x86 CPU feature bits
    */
    -#define NCAPINTS 18 /* N 32-bit words worth of info */
    +#define NCAPINTS 19 /* N 32-bit words worth of info */
    #define NBUGINTS 1 /* N 32-bit bug flags */

    /*
    @@ -206,8 +206,6 @@
    #define X86_FEATURE_RETPOLINE ( 7*32+12) /* Generic Retpoline mitigation for Spectre variant 2 */
    #define X86_FEATURE_RETPOLINE_AMD ( 7*32+13) /* AMD Retpoline mitigation for Spectre variant 2 */
    #define X86_FEATURE_INTEL_PPIN ( 7*32+14) /* Intel Processor Inventory Number */
    -#define X86_FEATURE_AVX512_4VNNIW ( 7*32+16) /* AVX-512 Neural Network Instructions */
    -#define X86_FEATURE_AVX512_4FMAPS ( 7*32+17) /* AVX-512 Multiply Accumulation Single precision */

    #define X86_FEATURE_MBA ( 7*32+18) /* Memory Bandwidth Allocation */
    #define X86_FEATURE_RSB_CTXSW ( 7*32+19) /* Fill RSB on context switches */
    @@ -319,6 +317,10 @@
    #define X86_FEATURE_SUCCOR (17*32+ 1) /* Uncorrectable error containment and recovery */
    #define X86_FEATURE_SMCA (17*32+ 3) /* Scalable MCA */

    +/* Intel-defined CPU features, CPUID level 0x00000007:0 (EDX), word 18 */
    +#define X86_FEATURE_AVX512_4VNNIW (18*32+ 2) /* AVX-512 Neural Network Instructions */
    +#define X86_FEATURE_AVX512_4FMAPS (18*32+ 3) /* AVX-512 Multiply Accumulation Single precision */
    +
    /*
    * BUG word(s)
    */
    diff --git a/arch/x86/include/asm/disabled-features.h b/arch/x86/include/asm/disabled-features.h
    index e428e16..c6a3af1 100644
    --- a/arch/x86/include/asm/disabled-features.h
    +++ b/arch/x86/include/asm/disabled-features.h
    @@ -71,6 +71,7 @@
    #define DISABLED_MASK15 0
    #define DISABLED_MASK16 (DISABLE_PKU|DISABLE_OSPKE|DISABLE_LA57)
    #define DISABLED_MASK17 0
    -#define DISABLED_MASK_CHECK BUILD_BUG_ON_ZERO(NCAPINTS != 18)
    +#define DISABLED_MASK18 0
    +#define DISABLED_MASK_CHECK BUILD_BUG_ON_ZERO(NCAPINTS != 19)

    #endif /* _ASM_X86_DISABLED_FEATURES_H */
    diff --git a/arch/x86/include/asm/required-features.h b/arch/x86/include/asm/required-features.h
    index d91ba04..fb3a6de 100644
    --- a/arch/x86/include/asm/required-features.h
    +++ b/arch/x86/include/asm/required-features.h
    @@ -106,6 +106,7 @@
    #define REQUIRED_MASK15 0
    #define REQUIRED_MASK16 (NEED_LA57)
    #define REQUIRED_MASK17 0
    -#define REQUIRED_MASK_CHECK BUILD_BUG_ON_ZERO(NCAPINTS != 18)
    +#define REQUIRED_MASK18 0
    +#define REQUIRED_MASK_CHECK BUILD_BUG_ON_ZERO(NCAPINTS != 19)

    #endif /* _ASM_X86_REQUIRED_FEATURES_H */
    diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c
    index 372ba3f..e5d66e9 100644
    --- a/arch/x86/kernel/cpu/common.c
    +++ b/arch/x86/kernel/cpu/common.c
    @@ -745,6 +745,7 @@ void get_cpu_cap(struct cpuinfo_x86 *c)
    cpuid_count(0x00000007, 0, &eax, &ebx, &ecx, &edx);
    c->x86_capability[CPUID_7_0_EBX] = ebx;
    c->x86_capability[CPUID_7_ECX] = ecx;
    + c->x86_capability[CPUID_7_EDX] = edx;
    }

    /* Extended state features: level 0x0000000d */
    diff --git a/arch/x86/kernel/cpu/scattered.c b/arch/x86/kernel/cpu/scattered.c
    index d0e6976..df11f5d 100644
    --- a/arch/x86/kernel/cpu/scattered.c
    +++ b/arch/x86/kernel/cpu/scattered.c
    @@ -21,8 +21,6 @@ struct cpuid_bit {
    static const struct cpuid_bit cpuid_bits[] = {
    { X86_FEATURE_APERFMPERF, CPUID_ECX, 0, 0x00000006, 0 },
    { X86_FEATURE_EPB, CPUID_ECX, 3, 0x00000006, 0 },
    - { X86_FEATURE_AVX512_4VNNIW, CPUID_EDX, 2, 0x00000007, 0 },
    - { X86_FEATURE_AVX512_4FMAPS, CPUID_EDX, 3, 0x00000007, 0 },
    { X86_FEATURE_CAT_L3, CPUID_EBX, 1, 0x00000010, 0 },
    { X86_FEATURE_CAT_L2, CPUID_EBX, 2, 0x00000010, 0 },
    { X86_FEATURE_CDP_L3, CPUID_ECX, 2, 0x00000010, 1 },
    --
    2.7.4
    \
     
     \ /
      Last update: 2018-01-25 17:16    [W:2.692 / U:0.268 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site