lkml.org 
[lkml]   [2018]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v1] x86/io: Define readq()/writeq() to use 64-bit type
From
Date
On Mon, 2018-01-22 at 16:46 -0800, hpa@zytor.com wrote:
> On January 22, 2018 4:32:14 PM PST, "Mehta, Sohil" <sohil.mehta@intel.
> com> wrote:
> > On Fri, 2018-01-19 at 16:33 +0200, Andy Shevchenko wrote:

> > > +build_mmio_read(readq, "q", unsigned long long, "=r", :"memory")
> > > +build_mmio_read(__readq, "q", unsigned long long, "=r", )
> > > +build_mmio_write(writeq, "q", unsigned long long, "r", :"memory")
> > > +build_mmio_write(__writeq, "q", unsigned long long, "r", )
> > >
> > > #define readq_relaxed(a) __readq(a)
> > > #define writeq_relaxed(v, a) __writeq(v, a)
> >
> > The patch works for me:
> >
> > Tested-by: Sohil Mehta <sohil.mehta@intel.com>
> >

> Wouldn't simply u64 make more sense?

It would break a common style used in this module for the rest of
accessors.

So, I prefer to go with unsigned long long and change later, if needed,
from POD types to uNN ones in entire file.

--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

\
 
 \ /
  Last update: 2018-01-23 09:32    [W:0.062 / U:0.392 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site