Messages in this thread |  | | Date | Mon, 22 Jan 2018 15:50:09 +0000 | From | Lee Jones <> | Subject | Re: [PATCH 2/3] mfd/omap-usb-tll: Improve a size determination in usbtll_omap_probe() |
| |
On Mon, 15 Jan 2018, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net> > Date: Mon, 15 Jan 2018 13:43:53 +0100 > > Replace the specification of a data structure by a pointer dereference > as the parameter for the operator "sizeof" to make the corresponding size > determination a bit safer according to the Linux coding style convention. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > --- > drivers/mfd/omap-usb-tll.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/mfd/omap-usb-tll.c b/drivers/mfd/omap-usb-tll.c > index 7945efa0152e..c8b4ad40910a 100644 > --- a/drivers/mfd/omap-usb-tll.c > +++ b/drivers/mfd/omap-usb-tll.c > @@ -220,8 +220,7 @@ static int usbtll_omap_probe(struct platform_device *pdev) > int i, ver; > > dev_dbg(dev, "starting TI HSUSB TLL Controller\n"); > -
Keep the space between.
> - tll = devm_kzalloc(dev, sizeof(struct usbtll_omap), GFP_KERNEL); > + tll = devm_kzalloc(dev, sizeof(*tll), GFP_KERNEL); > if (!tll) > return -ENOMEM; >
-- Lee Jones Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
|  |