| From | Arnd Bergmann <> | Date | Thu, 18 Jan 2018 10:56:53 +0100 | Subject | Re: [PATCH v6 03/36] sparc: io: To use the define of ioremap_[nocache|wc|wb] in asm-generic/io.h |
| |
On Mon, Jan 15, 2018 at 6:53 AM, Greentime Hu <green.hu@gmail.com> wrote: > From: Greentime Hu <greentime@andestech.com> > > It will be built failed if commit id: d25ea659 is selected. This patch > can fix this build error. > > Signed-off-by: Greentime Hu <greentime@andestech.com>
The change is fine, but the reference to commit 'd25ea659' is not for two reasons:
- when you rebase the tree, you will get a different ID - the recommended format for referring to another commit is to list it with 12 digits and the one-line summary like this:
commit d25ea659bc37 ("asm-generic/io.h: move ioremap_nocache/ioremap_uc/ioremap_wc/ioremap_…")
- Ideally you use a 'Fixes:' tag in the patch description.
You can add these lines in your .gitconfig to help you here
[alias] fixes = show --format='Fixes: %h (\"%s\")' -s [core] abbrev = 12
That will give you a 'git fixes' command to output the Fixes: line in the correct format for future bug fixes. For this particular change, I would actually just merge the two patches into one patch that then doesn't break anything in the first place.
Arnd
|