[lkml]   [2018]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] kbuild: fix W= option checks for extra DTC warnings
On Thu, Jan 18, 2018 at 4:31 AM, Masahiro Yamada
<> wrote:
> Kbuild supports 3 levels of extra warnings, and multiple levels can
> be combined, like W=12, W=123. It was added by commit a6de553da01c
> ("kbuild: Allow to combine multiple W= levels").
> From the log of commit 8654cb8d0371 ("dtc: update warning settings
> for new bus and node/property name checks"), I assume:
> - unit_address_vs_reg, simple_bus_reg, etc. belong to level 1
> - node_name_chars_strict, property_name_chars_strict belong to level 2
> However, the level 1 warnings are displayed by any argument to W=.
> On the other hand, the level 2 warnings are displayed by W=2, but
> not by W=12, or W=123.
> Use $(findstring ...) like scripts/Makefile.extrawarn.
> Signed-off-by: Masahiro Yamada <>

Good catch!

Acked-by: Arnd Bergmann <>

> Side Notes for possible additional works:
> [1] I implemented DTC extra warnings differently in U-Boot:
> Better to collect extra warning stuff into scripts/Makefile.extrawarn ?
> [2] KBUILD_ENABLE_EXTRA_GCC_CHECKS is getting a historical misnomer
> because we use it for Clang and DTC too.
> Better to rename? (keeping backward-compatibility for a while)?

I'd suggest we leave it for now, I still plan to eventually do my
large rework of
the way we handle extra warning levels, likely that will result in
being completely replaced.


 \ /
  Last update: 2018-01-18 10:26    [W:0.100 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site