lkml.org 
[lkml]   [2018]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] objtool: Fix seg fault with gold linker

* Josh Poimboeuf <jpoimboe@redhat.com> wrote:

> On Tue, Jan 16, 2018 at 01:21:44AM +0100, Ingo Molnar wrote:
> >
> > * Josh Poimboeuf <jpoimboe@redhat.com> wrote:
> >
> > > Objtool seg faults when the gold linker is used with
> > > CONFIG_MODVERSIONS=y and CONFIG_UNWINDER_ORC=y.
> > >
> > > With CONFIG_MODVERSIONS=y, the .o file gets passed to the linker before
> > > being passed to objtool. The gold linker seems to strip unused ELF
> > > symbols by default, which confuses objtool and causes the seg fault when
> > > it's trying to generate ORC metadata.
> >
> > BTW., if it's still unfixed, could we fix that segfault as well, and turn it into
> > a more useful failure message?
>
> Good point. I'll fix up this seg fault, and the other one
> found/introduced when adding retpoline support.

Thanks!

Ingo

\
 
 \ /
  Last update: 2018-01-16 09:31    [W:0.042 / U:0.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site