[lkml]   [2018]   [Jan]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH] sound/pci/hda: depends on instead of select for INPUT
From: Randy Dunlap <>

Drivers should not 'select' a subsystem. Instead they should depend
on it. If the subsystem is disabled, the user probably did that for
a purpose and one driver shouldn't be changing that.

This also makes all sound/ drivers consistent w.r.t depending on INPUT
instead of selecting it.

Signed-off-by: Randy Dunlap <>
Cc: Jaroslav Kysela <>
Cc: Takashi Iwai <>
Cc: (moderated for non-subscribers)
sound/pci/hda/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- lnx-415-rc8.orig/sound/pci/hda/Kconfig
+++ lnx-415-rc8/sound/pci/hda/Kconfig
@@ -87,8 +87,8 @@ config SND_HDA_PATCH_LOADER

tristate "Build Realtek HD-audio codec support"
+ depends on INPUT
- select INPUT
Say Y or M here to include Realtek HD-audio codec support in
snd-hda-intel driver, such as ALC880.
 \ /
  Last update: 2018-01-15 06:13    [W:0.075 / U:2.772 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site