[lkml]   [2018]   [Jan]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH] platform/x86: have ACPI_CMPC use depends instead of select for INPUT
From: Randy Dunlap <>

Drivers should not 'select' a subsystem. Instead they should depend
on it. If the subsystem is disabled, the user probably did that for
a purpose and one driver shouldn't be changing that.

This also makes all platform/x86/ drivers consistent w.r.t depending on
INPUT instead of selecting it.

Signed-off-by: Randy Dunlap <>
Cc: Darren Hart <>
Cc: Andy Shevchenko <>
drivers/platform/x86/Kconfig | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

--- lnx-415-rc8.orig/drivers/platform/x86/Kconfig
+++ lnx-415-rc8/drivers/platform/x86/Kconfig
@@ -812,9 +812,8 @@ config TOSHIBA_WMI

config ACPI_CMPC
tristate "CMPC Laptop Extras"
- depends on ACPI
+ depends on ACPI && INPUT
depends on RFKILL || RFKILL=n
- select INPUT
Support for Intel Classmate PC ACPI devices, including some
 \ /
  Last update: 2018-01-15 06:12    [W:0.037 / U:2.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site