[lkml]   [2018]   [Jan]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [patch v8 2/3] platform/mellanox: mlxreg-hotplug: allow driver for ARM architecture
On Thu, Jan 11, 2018 at 08:58:42AM +0000, Vadim Pasternak wrote:
> It allows driver to run on x86 and ARM architecture based systems.
> Also some unnecessary includes are removed.

Hi Vadim,

These changes are not all readily mapped to this description, nor to the
changelog below.

Only the kconfig change is obviously linked to building on ARM and not just x86.

Things like the removal of the dev_err messages and the relocation of the
create and destroy methods seem entirely unrelated to building on ARM.

I'd like to get this merged sooner rather than later as it has been lingering
for quite some time now - can you provide some more detail about how the changes
included in this patch are needed to make this driver build on ARM?


Darren Hart
VMware Open Source Technology Center

 \ /
  Last update: 2018-01-16 04:44    [W:0.421 / U:0.680 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site