[lkml]   [2018]   [Jan]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 39/40] drm/rockchip: analogix_dp: Fix invalid implementation of unbind
Hi Thierry,

On Tue, Jan 16, 2018 at 2:16 AM, Thierry Escande
<> wrote:
> From: Tomasz Figa <>
> Current implementation of unbind dereferences the drvdata pointer
> assuming that it's its own data, however the ownership belongs to the
> analogix code, which means that the pointer is dereferenced with wrong
> type. Fix this by using the recently added platform data .cleanup()
> callback to do Rockchip-specific things at unbind.

First of all, thanks a lot for taking care of these patches. Much appreciated.

One thing to note, though, is that the four patches (31, 32, 33 and 39
in this series), which we initially made for fixing the problems
related, were later reverted and replaced by a cleaner solution.
Please take a look at this series on our gerrit:

Perhaps we could skip this intermediate solution and just go with the
above 3 patches?

Best regards,

 \ /
  Last update: 2018-01-16 03:18    [W:1.586 / U:0.492 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site