lkml.org 
[lkml]   [2018]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 04/14] mmc: mmci: Add STM32 variant
On Fri, Jan 12, 2018 at 1:15 PM,  <patrice.chotard@st.com> wrote:

> From: Patrice Chotard <patrice.chotard@st.com>
>
> STM32F4 and STM32F7 MCUs has a SDIO controller that looks like
> an ARM pl810.

PL180 you mean. Ulf can fix while applying.

> This patch adds the STM32 variant so that mmci driver supports it.
>
> Signed-off-by: Andrea Merello <andrea.merello@gmail.com>
> Signed-off-by: Patrice Chotard <patrice.chotard@st.com>

(...)
> +static struct variant_data variant_stm32 = {
> + .fifosize = 32 * 4,
> + .fifohalfsize = 8 * 4,
> + .clkreg = MCI_CLK_ENABLE,
> + .clkreg_enable = MCI_ST_UX500_HWFCEN,

If the asic designed derived this from ux500 I guess it is proper.

> + .clkreg_8bit_bus_enable = MCI_ST_8BIT_BUS,
> + .clkreg_neg_edge_enable = MCI_ST_UX500_NEG_EDGE,
> + .datalength_bits = 24,
> + .datactrl_mask_sdio = MCI_DPSM_ST_SDIOEN,
> + .st_sdio = true,

Did you test SDIO? I think we lack features for that.

> + {
> + .id = 0x00880180,
> + .mask = 0x00ffffff,
> + .data = &variant_stm32,
> + },

Since ux500 was 480180 I wonder what variants 5,6,7 are...

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

\
 
 \ /
  Last update: 2018-01-15 02:14    [W:0.732 / U:0.620 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site