lkml.org 
[lkml]   [2018]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V4 3/8] perf/x86/intel/uncore: correct fixed counter index check in generic code
On Thu, 2 Nov 2017, kan.liang@intel.com wrote:

> From: Kan Liang <Kan.liang@intel.com>
>
> There is no index which is bigger than UNCORE_PMC_IDX_FIXED. The only
> exception is client IMC uncore. It has customized function to deal with
> the 'UNCORE_PMC_IDX_FIXED + 1' case. It does not touch the generic code.
> For generic code, it is not correct to use >= to check fixed counter.
> The code quality issue will bring problem when new counter index is
> introduced.
>
> Signed-off-by: Kan Liang <Kan.liang@intel.com>

Reviewed-by: Thomas Gleixner <tglx@linutronix.de>

\
 
 \ /
  Last update: 2018-01-14 23:27    [W:0.089 / U:2.512 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site