[lkml]   [2018]   [Jan]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] retpoline/module: Taint kernel for missing retpoline in module
> > When the a module hasn't been compiled with a retpoline
> > aware compiler, print a warning and set a taint flag.
> Isn't that caught by the "build with a different compiler/version" check
> that we have? Or used to have? If not, can't we just make it into that

- the compiler version number may not change if a distribution backports
the gcc changes for the new flag
- the module might be using a custom make file that does not correctly
set the flag, even if the compiler supports it

> type of check to catch this type of problem no matter what type of
> feature/option it is trying to catch?

I suspect that would be far more complicated. Also what's the point
of putting this information into every symbol? Once per module
is good enough.

We already have similar checks for staging etc.


 \ /
  Last update: 2018-01-14 23:26    [W:0.102 / U:2.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site