lkml.org 
[lkml]   [2018]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v2 08/16] remoteproc: add name in rproc_mem_entry struct
Date


> -----Original Message-----
> From: Bjorn Andersson [mailto:bjorn.andersson@linaro.org]
> Sent: Thursday, December 14, 2017 2:21 AM
> To: Loic PALLARDY <loic.pallardy@st.com>
> Cc: ohad@wizery.com; linux-remoteproc@vger.kernel.org; linux-
> kernel@vger.kernel.org; Arnaud POULIQUEN <arnaud.pouliquen@st.com>;
> benjamin.gaignard@linaro.org
> Subject: Re: [PATCH v2 08/16] remoteproc: add name in rproc_mem_entry
> struct
>
> On Thu 30 Nov 08:46 PST 2017, Loic Pallardy wrote:
>
> > Add name field in struc rproc_mem_entry.
> > This new field will be used to match memory area
> > requested in resource table with pre-registered carveout.
> >
> > Signed-off-by: Loic Pallardy <loic.pallardy@st.com>
> > ---
> > drivers/remoteproc/remoteproc_core.c | 1 +
> > drivers/remoteproc/remoteproc_debugfs.c | 1 +
> > include/linux/remoteproc.h | 2 ++
> > 3 files changed, 4 insertions(+)
> >
> > diff --git a/drivers/remoteproc/remoteproc_core.c
> b/drivers/remoteproc/remoteproc_core.c
> > index bdc99cd..cc53247 100644
> > --- a/drivers/remoteproc/remoteproc_core.c
> > +++ b/drivers/remoteproc/remoteproc_core.c
> > @@ -835,6 +835,7 @@ static int rproc_handle_carveout(struct rproc
> *rproc,
> > carveout->da = rsc->da;
> > carveout->release = rproc_release_carveout;
> > carveout->priv = (void *)CARVEOUT_RSC_ALLOCATED;
> > + strncpy(carveout->name, rsc->name, sizeof(carveout->name));
>
> Please ensure that this string is NUL terminated.

I'll use strlcpy instead

Regards,
Loic
>
> Regards,
> Bjorn

\
 
 \ /
  Last update: 2018-01-14 23:25    [W:0.075 / U:1.372 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site