Messages in this thread |  | | Date | Fri, 8 Sep 2017 10:57:40 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH RFC 1/6] The file ksz_common.c will be used by other KSZ switch drivers. |
| |
> > > Signed-off-by: Tristram Ha <Tristram.Ha@microchip.com> > > > --- > > > diff --git a/drivers/net/dsa/microchip/Makefile > > > b/drivers/net/dsa/microchip/Makefile > > > index ed335e2..0961c30 100644 > > > --- a/drivers/net/dsa/microchip/Makefile > > > +++ b/drivers/net/dsa/microchip/Makefile > > > @@ -1,2 +1,2 @@ > > > -obj-$(CONFIG_MICROCHIP_KSZ) += ksz_common.o > > > +obj-$(CONFIG_MICROCHIP_KSZ) += ksz9477.o ksz_common.o > > > obj-$(CONFIG_MICROCHIP_KSZ_SPI_DRIVER) += ksz_spi.o > > > > Hi Tristram > > > > I would of thought this would break the build. You don't add ksz9477.c until the > > next patch. > > > > Each patch needs to compile, otherwise you break git bisect. > > > > Andrew > > Eventually the file will need to be broken in two, so you would like >to see all 3 changes (Makefile, ksz_common.c, and ksz9477.c) in 1 > patch file?
Yes please. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html [unhandled content-type:application/pgp-signature]
|  |