lkml.org 
[lkml]   [2017]   [Sep]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 00/12] x86/crypto: Fix RBP usage in several crypto .S files

    * Eric Biggers <ebiggers3@gmail.com> wrote:

    > On Thu, Sep 07, 2017 at 09:15:34AM +0200, Ingo Molnar wrote:
    > >
    > > * Eric Biggers <ebiggers3@gmail.com> wrote:
    > >
    > > > Thanks for fixing these! I don't have time to review these in detail, but I ran
    > > > the crypto self-tests on the affected algorithms, and they all pass. I also
    > > > benchmarked them before and after; the only noticable performance difference was
    > > > that sha256-avx2 and sha512-avx2 became a few percent slower. I don't suppose
    > > > there is a way around that? Otherwise it's probably not a big deal.
    > >
    > > Which CPU model did you use for the test?
    > >
    > > Thanks,
    > >
    > > Ingo
    >
    > This was on Haswell, "Intel(R) Xeon(R) CPU E5-1650 v3 @ 3.50GHz".

    Any chance to test this with the latest microarchitecture - any Skylake derivative
    Intel CPU you have access to?

    Thanks,

    Ingo

    \
     
     \ /
      Last update: 2017-09-07 23:27    [W:8.390 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site