lkml.org 
[lkml]   [2017]   [Sep]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v3 3/8] platform/x86: dell-wmi-smbios: Use Dell WMI descriptor check
Date
On Saturday 30 September 2017 21:48:39 Mario.Limonciello@dell.com wrote:
> > > +/*
> >
> > > + * Descriptor buffer is 128 byte long and contains:
> > ...
> >
> > > + if (obj->buffer.length != 128) {
> > > + dev_err(&wdev->dev,
> > > + "Dell descriptor buffer has invalid length (%d)\n",
> > > + obj->buffer.length);
> >
> > This seems odd. We call it an error (not a warning) if != 128, but
> > we only abort and return an error if it's < 16.
> >
> > If it's an error, we should return an error code, if anything above
> > 16 is acceptable but 128 is preferred, the above should be a
> > warning at best. (this scenario seems unlikely).
>
> Hopefully the original author can speak up to the intentions here. I
> would feel that it should have errored out if it wasn't expected
> length too.

Code below access first 16 bytes of buffer. Therefore to prevent buffer
overflow check for 16 bytes is needed.

But IIRC we decided to do not throw error and continue driver loading
even when buffer length is not 128 (as expected by some Dell
documentation) as it could be possible regression because driver itself
does not depend on buffer length.

> > > + if (obj->buffer.length < 16) {
> > > + ret = -EINVAL;
> > > + goto out;
> > > + }
> > > + }
> > > + desc_buffer = (u32 *)obj->buffer.pointer;
> > > +
> > > + if (desc_buffer[0] != 0x4C4C4544 && desc_buffer[1] !=
> > > 0x494D5720)

--
Pali Rohár
pali.rohar@gmail.com
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2017-09-30 22:01    [W:0.237 / U:0.348 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site