lkml.org 
[lkml]   [2017]   [Sep]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 02/14] platform/x86: dell-smbios: drop needless includes
On Wed, Sep 27, 2017 at 10:40:19AM -0700, Darren Hart wrote:
> On Tue, Sep 26, 2017 at 01:50:00PM -0500, Mario Limonciello wrote:
> > These aren't needed to compile the module.
> >
> > Signed-off-by: Mario Limonciello <mario.limonciello@dell.com>
>
> Hrm...
>
> CONFIG_DELL_SMBIOS=m
>
> $ make drivers/platform/x86/dell-smbios.ko
>
> CC [M] drivers/platform/x86/dell-smbios.o
> drivers/platform/x86/dell-smbios.c: In function ‘parse_da_table’:
> drivers/platform/x86/dell-smbios.c:142:18: error: implicit declaration of function ‘krealloc’ [-Werror=implicit-function-declaration]
> new_da_tokens = krealloc(da_tokens, (da_num_tokens + tokens) *
> ^~~~~~~~
> drivers/platform/x86/dell-smbios.c:142:16: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
> new_da_tokens = krealloc(da_tokens, (da_num_tokens + tokens) *
> ^
> drivers/platform/x86/dell-smbios.c: In function ‘dell_smbios_init’:
> drivers/platform/x86/dell-smbios.c:193:2: error: implicit declaration of function ‘kfree’ [-Werror=implicit-function-declaration]
> kfree(da_tokens);
> ^~~~~
>
> > ---
> > drivers/platform/x86/dell-smbios.c | 3 ---
...
> > -#include <linux/slab.h>
>
> Appears you do require slab.h...
>

I've dropped this one line from this patch, and build is working again. Patches
1-7 look ready to go to me. I'm pushing these to my review branch from some
additional automated testing.

Let me know if there are any objections for 1-7. If we can get these queued now,
we can simplify the review effort for the major functional changes in 8-14.

--
Darren Hart
VMware Open Source Technology Center

\
 
 \ /
  Last update: 2017-09-27 19:58    [W:0.122 / U:2.396 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site