lkml.org 
[lkml]   [2017]   [Sep]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v2 02/14] platform/x86: dell-smbios: drop needless includes
Date
> -----Original Message-----
> From: Darren Hart [mailto:dvhart@infradead.org]
> Sent: Wednesday, September 27, 2017 1:40 PM
> To: Limonciello, Mario <Mario_Limonciello@Dell.com>
> Cc: Andy Shevchenko <andy.shevchenko@gmail.com>; LKML <linux-
> kernel@vger.kernel.org>; platform-driver-x86@vger.kernel.org;
> quasisec@google.com; pali.rohar@gmail.com
> Subject: Re: [PATCH v2 02/14] platform/x86: dell-smbios: drop needless includes
>
> On Tue, Sep 26, 2017 at 01:50:00PM -0500, Mario Limonciello wrote:
> > These aren't needed to compile the module.
> >
> > Signed-off-by: Mario Limonciello <mario.limonciello@dell.com>
>
> Hrm...
>
> CONFIG_DELL_SMBIOS=m
>
> $ make drivers/platform/x86/dell-smbios.ko
>
> CC [M] drivers/platform/x86/dell-smbios.o
> drivers/platform/x86/dell-smbios.c: In function ‘parse_da_table’:
> drivers/platform/x86/dell-smbios.c:142:18: error: implicit declaration of function
> ‘krealloc’ [-Werror=implicit-function-declaration]
> new_da_tokens = krealloc(da_tokens, (da_num_tokens + tokens) *
> ^~~~~~~~
> drivers/platform/x86/dell-smbios.c:142:16: warning: assignment makes pointer
> from integer without a cast [-Wint-conversion]
> new_da_tokens = krealloc(da_tokens, (da_num_tokens + tokens) *
> ^
> drivers/platform/x86/dell-smbios.c: In function ‘dell_smbios_init’:
> drivers/platform/x86/dell-smbios.c:193:2: error: implicit declaration of function
> ‘kfree’ [-Werror=implicit-function-declaration]
> kfree(da_tokens);
> ^~~~~
>

Thanks, I've obviously been testing this and didn't notice it.
Not sure why that wasn't exploding on my end.
Anyway I'll fix for v3.

> > ---
> > drivers/platform/x86/dell-smbios.c | 3 ---
> > 1 file changed, 3 deletions(-)
> >
> > diff --git a/drivers/platform/x86/dell-smbios.c b/drivers/platform/x86/dell-
> smbios.c
> > index 0a5723468bff..6654ad44a04c 100644
> > --- a/drivers/platform/x86/dell-smbios.c
> > +++ b/drivers/platform/x86/dell-smbios.c
> > @@ -17,10 +17,7 @@
> > #include <linux/module.h>
> > #include <linux/dmi.h>
> > #include <linux/err.h>
> > -#include <linux/gfp.h>
> > #include <linux/mutex.h>
> > -#include <linux/slab.h>
>
> Appears you do require slab.h...
>
> > -#include <linux/io.h>
> > #include "../../firmware/dcdbas.h"
> > #include "dell-smbios.h"
> >
> > --
> > 2.14.1
>
>
>
> >
> >
>
> --
> Darren Hart
> VMware Open Source Technology Center
\
 
 \ /
  Last update: 2017-09-27 19:44    [W:0.063 / U:0.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site