lkml.org 
[lkml]   [2017]   [Sep]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] platform/x86: intel-hid: Power button suspend on Dell Latitude 7275
On Sat, Sep 23, 2017 at 2:45 AM, Darren Hart <dvhart@infradead.org> wrote:
> On Mon, Sep 18, 2017 at 12:57:12AM +0200, Jérôme de Bretagne wrote:

>> + if (event == 0xce) {
>> + input_report_key(priv->input_dev, KEY_POWER, 1);
>> + input_sync(priv->input_dev);
>> + return;
>> + } else if (event == 0xcf)
>> + return;
>
> Minor CodingStyle nit. If the if block uses parens, so does the else block. In
> this case, since the if returns, just skip the else entirely.
>
> See Documentation/process/coding-style.rst
> The example immediatley *before* 3.1) Spaces.
>
> I've made this change and queued for testing.
>
>> + }

Actually in this case even 'else' is redundant.

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2017-09-25 12:58    [W:0.105 / U:1.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site