Messages in this thread |  | | From | Andy Shevchenko <> | Date | Mon, 25 Sep 2017 13:57:48 +0300 | Subject | Re: [PATCH] platform/x86: intel-hid: Power button suspend on Dell Latitude 7275 |
| |
On Sat, Sep 23, 2017 at 2:45 AM, Darren Hart <dvhart@infradead.org> wrote: > On Mon, Sep 18, 2017 at 12:57:12AM +0200, Jérôme de Bretagne wrote:
>> + if (event == 0xce) { >> + input_report_key(priv->input_dev, KEY_POWER, 1); >> + input_sync(priv->input_dev); >> + return; >> + } else if (event == 0xcf) >> + return; > > Minor CodingStyle nit. If the if block uses parens, so does the else block. In > this case, since the if returns, just skip the else entirely. > > See Documentation/process/coding-style.rst > The example immediatley *before* 3.1) Spaces. > > I've made this change and queued for testing. > >> + }
Actually in this case even 'else' is redundant.
-- With Best Regards, Andy Shevchenko
|  |