lkml.org 
[lkml]   [2017]   [Sep]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC PATCH 0/7] AXP803 AC/Battery support
From
Date
Hi Icenowy,

On 24/09/2017 16:36, Jonathan Cameron wrote:
> On Thu, 21 Sep 2017 23:20:11 +0800
> Icenowy Zheng <icenowy@aosc.io> wrote:
>
>> 于 2017年9月21日 GMT+08:00 下午10:46:21, Jonathan Cameron <Jonathan.Cameron@huawei.com> 写到:
>>> On Wed, 20 Sep 2017 23:18:07 +0800
>>> Icenowy Zheng <icenowy@aosc.io> wrote:
>>>
>>>> The AXP803 PMIC, used by most Allwinner A64 boards, features 3 power
>>> inputs:
>>>> AC, USB and Battery.
>>>>
>>>> This patchset adds support for the AC and Battery supplies, which is
>>> useful
>>>> for the boards from Pine64 (Pine64, SoPine w/ baseboard model A,
>>> Pinebook).
>>>>
>>>> The USB supply is not yet supported in this patchset because it's not
>>>> present on Pine series boards.
>>>>
>>>> In order to enable battery monitoring the ADC for battery is also
>>> enabled
>>>> for AXs.
>>>>
>>>> In order to enable battery monitoring the ADC for battery is also
>>> enabled
>>>> for AXP803.
>>>
>>> I'll go with the obvious question...
>>>
>>> Why an RFC rather than a standard patch submission? I'm not immediately
>>> seeing what is controversial!
>>
>> Oh I am just not confident about this patchset,
>> especially the IIO part.
>
> It all looks fine to me. I would imagine that, once everyone is
> happy, this will go through the mfd tree, but Lee may have other ideas!
>

Small modifications to make but I definitely agree with Jonathan that
you did not need to send an RFC.

Quentin

> Jonathan
>>
>>>
>>> Jonathan
>>>
>>>>
>>>> Icenowy Zheng (7):
>>>> dt-bindings: add compatibles for AXP803 Battery/USB power supplies
>>>> iio: adc: axp20x-adc: allow to skip ADC rate setup now
>>>> iio: adc: axp20x-adc: add support for AXP803
>>>> power: supply: axp20x-battery: support AXP803
>>>> mfd: axp20x: add cells for AXP803 ADC/AC Power/Battery
>>>> arm64: allwinner: a64: add power supply nodes in AXP803 DTSI
>>>> arm64: allwinner: a64: enable AC and Battery for Pine64
>>>>
>>>> .../bindings/power/supply/axp20x_battery.txt | 1 +
>>>> .../bindings/power/supply/axp20x_usb_power.txt | 1 +
>>>> arch/arm64/boot/dts/allwinner/axp803.dtsi | 15 +++
>>>> .../arm64/boot/dts/allwinner/sun50i-a64-pine64.dts | 8 ++
>>>> drivers/iio/adc/axp20x_adc.c | 114
>>> ++++++++++++++++++++-
>>>> drivers/mfd/axp20x.c | 11 ++
>>>> drivers/power/supply/axp20x_battery.c | 88
>>> ++++++++++++++--
>>>> 7 files changed, 226 insertions(+), 12 deletions(-)
>>>>
>>>
>>>
>>> _______________________________________________
>>> linux-arm-kernel mailing list
>>> linux-arm-kernel@lists.infradead.org
>>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>

--
Quentin Schulz, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

\
 
 \ /
  Last update: 2017-09-25 11:23    [W:0.048 / U:1.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site