lkml.org 
[lkml]   [2017]   [Sep]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v6 2/3] eeprom: at24: add support to fetch eeprom device property "size"
On Wed, Sep 20, 2017 at 6:52 AM, Mani, Rajmohan <rajmohan.mani@intel.com> wrote:
> Adding Tomasz...

Please, don't top post.
Better to resend entire series with all stakeholders included.

>> Obtain the size of the EEPROM chip from DT if the "size" property is specified
>> for the device.
>>

I guess it lacks
Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Other than that, looks good to me!

Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>


Wolfram, the binding is ACKed by Rob and this one is in a good shape.
Moreover, it seems like a demand for the property since some IoT stuff
would like to use the driver on ACPI enabled platforms with different
sizes.

Can you go ahead and apply first two patches? It would be really appreciated.

>> Signed-off-by: Divagar Mohandass <divagar.mohandass@intel.com>
>> ---
>> drivers/misc/eeprom/at24.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c index
>> 764ff5df..2199c42 100644
>> --- a/drivers/misc/eeprom/at24.c
>> +++ b/drivers/misc/eeprom/at24.c
>> @@ -570,6 +570,10 @@ static void at24_get_pdata(struct device *dev, struct
>> at24_platform_data *chip)
>> if (device_property_present(dev, "read-only"))
>> chip->flags |= AT24_FLAG_READONLY;
>>
>> + err = device_property_read_u32(dev, "size", &val);
>> + if (!err)
>> + chip->byte_len = val;
>> +
>> err = device_property_read_u32(dev, "pagesize", &val);
>> if (!err) {
>> chip->page_size = val;
>> --
>> 1.9.1
>



--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2017-09-22 18:12    [W:0.063 / U:2.792 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site