lkml.org 
[lkml]   [2017]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH net] net/ncsi: Don't assume last available channel exists
    Date
    When handling new VLAN tags in NCSI we check the maximum allowed number
    of filters on the last active ("hot") channel. However if the 'add'
    callback is called before NCSI has configured a channel, this causes a
    NULL dereference.

    Check that we actually have a hot channel, and warn if it is missing.

    Signed-off-by: Samuel Mendoza-Jonas <sam@mendozajonas.com>
    ---
    net/ncsi/ncsi-manage.c | 21 +++++++++++++++------
    1 file changed, 15 insertions(+), 6 deletions(-)

    diff --git a/net/ncsi/ncsi-manage.c b/net/ncsi/ncsi-manage.c
    index 3fd3c39e6278..fc800f934beb 100644
    --- a/net/ncsi/ncsi-manage.c
    +++ b/net/ncsi/ncsi-manage.c
    @@ -1420,7 +1420,10 @@ int ncsi_vlan_rx_add_vid(struct net_device *dev, __be16 proto, u16 vid)
    }

    ndp = TO_NCSI_DEV_PRIV(nd);
    - ncf = ndp->hot_channel->filters[NCSI_FILTER_VLAN];
    + if (!ndp) {
    + netdev_warn(dev, "ncsi: No ncsi_dev_priv?\n");
    + return 0;
    + }

    /* Add the VLAN id to our internal list */
    list_for_each_entry_rcu(vlan, &ndp->vlan_vids, list) {
    @@ -1432,11 +1435,17 @@ int ncsi_vlan_rx_add_vid(struct net_device *dev, __be16 proto, u16 vid)
    }
    }

    - if (n_vids >= ncf->total) {
    - netdev_info(dev,
    - "NCSI Channel supports up to %u VLAN tags but %u are already set\n",
    - ncf->total, n_vids);
    - return -EINVAL;
    + if (!ndp->hot_channel) {
    + netdev_warn(dev,
    + "ncsi: no available filter to check maximum\n");
    + } else {
    + ncf = ndp->hot_channel->filters[NCSI_FILTER_VLAN];
    + if (n_vids >= ncf->total) {
    + netdev_info(dev,
    + "NCSI Channel supports up to %u VLAN tags but %u are already set\n",
    + ncf->total, n_vids);
    + return -EINVAL;
    + }
    }

    vlan = kzalloc(sizeof(*vlan), GFP_KERNEL);
    --
    2.14.1
    \
     
     \ /
      Last update: 2017-09-20 06:14    [W:2.387 / U:0.192 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site