Messages in this thread Patch in this message |  | | From | Frederic Weisbecker <> | Subject | [PATCH 02/12] watchdog: Use housekeeping_cpumask() instead of ad-hoc version | Date | Mon, 18 Sep 2017 15:53:59 +0200 |
| |
While trying to disable the watchog on nohz_full CPUs, the watchdog implements an ad-hoc version of housekeeping_cpumask(). Lets replace those re-invented lines.
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com> Cc: Chris Metcalf <cmetcalf@mellanox.com> Cc: Rik van Riel <riel@redhat.com> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Mike Galbraith <efault@gmx.de> Cc: Ingo Molnar <mingo@kernel.org> Cc: Christoph Lameter <cl@linux.com> Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Cc: Wanpeng Li <kernellwp@gmail.com> Cc: Luiz Capitulino <lcapitulino@redhat.com> --- kernel/watchdog.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/kernel/watchdog.c b/kernel/watchdog.c index 3cc5596..e672752 100644 --- a/kernel/watchdog.c +++ b/kernel/watchdog.c @@ -942,15 +942,10 @@ void __init lockup_detector_init(void) { set_sample_period(); -#ifdef CONFIG_NO_HZ_FULL - if (tick_nohz_full_enabled()) { + if (tick_nohz_full_enabled()) pr_info("Disabling watchdog on nohz_full cores by default\n"); - cpumask_copy(&watchdog_cpumask, housekeeping_mask); - } else - cpumask_copy(&watchdog_cpumask, cpu_possible_mask); -#else - cpumask_copy(&watchdog_cpumask, cpu_possible_mask); -#endif + + cpumask_copy(&watchdog_cpumask, housekeeping_cpumask()); if (watchdog_enabled) watchdog_enable_all_cpus(); -- 2.7.4
|  |