lkml.org 
[lkml]   [2017]   [Sep]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] drm/vmwgfx: remove DRM_ERROR message, stops log spamming
    Date
    From: Colin Ian King <colin.king@canonical.com>

    mmap'ing the device multiple times will spam the kernel log with the
    DRM_ERROR message about illegal mmap'ing the old fifo space. Since
    the mmap'ing will fail with an -EINVAL there is no need to emit this
    message, so just remove it.

    Signed-off-by: Colin Ian King <colin.king@canonical.com>
    ---
    drivers/gpu/drm/vmwgfx/vmwgfx_ttm_glue.c | 4 +---
    1 file changed, 1 insertion(+), 3 deletions(-)

    diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_glue.c b/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_glue.c
    index e771091d2cd3..1e633c602fb1 100644
    --- a/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_glue.c
    +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_glue.c
    @@ -33,10 +33,8 @@ int vmw_mmap(struct file *filp, struct vm_area_struct *vma)
    struct drm_file *file_priv;
    struct vmw_private *dev_priv;

    - if (unlikely(vma->vm_pgoff < VMWGFX_FILE_PAGE_OFFSET)) {
    - DRM_ERROR("Illegal attempt to mmap old fifo space.\n");
    + if (unlikely(vma->vm_pgoff < VMWGFX_FILE_PAGE_OFFSET))
    return -EINVAL;
    - }

    file_priv = filp->private_data;
    dev_priv = vmw_priv(file_priv->minor->dev);
    --
    2.14.1
    \
     
     \ /
      Last update: 2017-09-12 19:36    [W:24.411 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site