Messages in this thread |  | | Subject | Re: [PATCH 13/18] power: supply: bq24190_charger: Export 5V boost converter as regulator | From | Hans de Goede <> | Date | Tue, 8 Aug 2017 11:00:33 +0200 |
| |
Hi,
On 08-08-17 10:39, Liam Breck wrote: > Hi Hans, > > On Sun, Aug 6, 2017 at 5:35 AM, Hans de Goede <hdegoede@redhat.com> wrote: >> Register the 5V boost converter as a regulator named >> "regulator-bq24190-usb-vbus". Note the name includes "bq24190" because >> the bq24190 family is also used on ACPI devices where there are no >> device-tree phandles, so regulator_get will fallback to the name and thus >> it must be unique on the system. > > What we're enabling here is 5V boost for otg host mode, not vbus > generally, so maybe the name should indicate that... > > regulator-bq24190-usb-5volt > regulator-bq24190-usb-host > regulator-bq24190-usb-otg-5v
I picked vbus because that gets used a lot already in similar cases, but I agree that we should probably come up with a better name.
I like "regulator-bq24190-usb-otg-5v", shall I use that for v2?
Regards,
Hans
|  |