lkml.org 
[lkml]   [2017]   [Aug]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 2/2] gpio: 74x164: handling enable-gpios
Date
> > +       chip->enable_gpio = devm_gpiod_get(&spi->dev, "enable",
> GPIOD_OUT_LOW);
> > + if (IS_ERR(chip->enable_gpio)) {
> > + dev_dbg(&spi->dev, "No enable-gpios property\n");
> > + chip->enable_gpio = NULL;
>
> Also, the error handling here is not correct as it will never propagate
> EPROBE_DEFER.
>
> I will submit my version of the patch if you don't mind.

That's ok if you have a better patch.

Regards,
Peng.
\
 
 \ /
  Last update: 2017-08-08 03:15    [W:0.063 / U:2.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site