lkml.org 
[lkml]   [2017]   [Aug]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/5] parport: cleanup prohibited space after functions name
On Mon, Jul 17, 2017 at 05:36:59PM +0100, Carlos Palminha wrote:
> based on checkpatch, remove prohibited space between function name and
> open parenthesis '('.
>
> Signed-off-by: Carlos Palminha <palminha@synopsys.com>
> ---
> drivers/parport/ieee1284.c | 212 ++++++++++++------------
> drivers/parport/ieee1284_ops.c | 338 +++++++++++++++++++--------------------
> drivers/parport/parport_atari.c | 4 +-
> drivers/parport/parport_gsc.c | 62 +++----
> drivers/parport/parport_mfc3.c | 2 +-
> drivers/parport/parport_serial.c | 52 +++---
> drivers/parport/parport_sunbpp.c | 6 +-
> drivers/parport/probe.c | 42 ++---
> drivers/parport/procfs.c | 22 +--
> 9 files changed, 370 insertions(+), 370 deletions(-)
>
> diff --git a/drivers/parport/ieee1284.c b/drivers/parport/ieee1284.c
> index b40ee76d519d..27673b838e74 100644
> --- a/drivers/parport/ieee1284.c
> +++ b/drivers/parport/ieee1284.c
> @@ -32,22 +32,22 @@
> #endif
>
> #ifdef DEBUG
> -#define DPRINTK(stuff...) printk (stuff)
> +#define DPRINTK(stuff...) printk(stuff)
> #else
> #define DPRINTK(stuff...)
> #endif
>
> /* Make parport_wait_peripheral wake up.
> * It will be useful to call this from an interrupt handler. */
> -static void parport_ieee1284_wakeup (struct parport *port)
> +static void parport_ieee1284_wakeup(struct parport *port)
> {
> - up (&port->physport->ieee1284.irq);
> + up(&port->physport->ieee1284.irq);
> }
>
> static struct parport *port_from_cookie[PARPORT_MAX];
> -static void timeout_waiting_on_port (unsigned long cookie)
> +static void timeout_waiting_on_port(unsigned long cookie)
> {
> - parport_ieee1284_wakeup (port_from_cookie[cookie % PARPORT_MAX]);
> + parport_ieee1284_wakeup(port_from_cookie[cookie % PARPORT_MAX]);
> }
>
> /**
> @@ -66,7 +66,7 @@ static void timeout_waiting_on_port (unsigned long cookie)
> * what it's doing as soon as it can.
> */
>
> -int parport_wait_event (struct parport *port, signed long timeout)
> +int parport_wait_event(struct parport *port, signed long timeout)
> {
> int ret;
> struct timer_list timer;
> @@ -82,8 +82,8 @@ int parport_wait_event (struct parport *port, signed long timeout)
> port_from_cookie[port->number % PARPORT_MAX] = port;
> timer.data = port->number;
>
> - add_timer (&timer);
> - ret = down_interruptible (&port->physport->ieee1284.irq);
> + add_timer(&timer);
> + ret = down_interruptible(&port->physport->ieee1284.irq);
> if (!del_timer_sync(&timer) && !ret)
> /* Timed out. */
> ret = 1;
> @@ -127,15 +127,15 @@ int parport_poll_peripheral(struct parport *port,
> int i;
> unsigned char status;
> for (i = 0; i < count; i++) {
> - status = parport_read_status (port);
> + status = parport_read_status(port);
> if ((status & mask) == result)
> return 0;
> - if (signal_pending (current))
> + if (signal_pending(current))
> return -EINTR;
> if (need_resched())
> break;
> if (i >= 2)
> - udelay (5);
> + udelay(5);
> }
>
> return 1;
> @@ -187,7 +187,7 @@ int parport_wait_peripheral(struct parport *port,
> * How about making a note (in the device structure) of how long
> * it takes, so we know for next time?
> */
> - ret = parport_poll_peripheral (port, mask, result, usec);
> + ret = parport_poll_peripheral(port, mask, result, usec);
> if (ret != 1)
> return ret;
>
> @@ -198,16 +198,16 @@ int parport_wait_peripheral(struct parport *port,
>
> /* 40ms of slow polling. */
> deadline = jiffies + msecs_to_jiffies(40);
> - while (time_before (jiffies, deadline)) {
> - if (signal_pending (current))
> + while (time_before(jiffies, deadline)) {
> + if (signal_pending(current))
> return -EINTR;
>
> /* Wait for 10ms (or until an interrupt occurs if
> * the handler is set) */
> - if ((ret = parport_wait_event (port, msecs_to_jiffies(10))) < 0)
> + if ((ret = parport_wait_event(port, msecs_to_jiffies(10))) < 0)
> return ret;
>
> - status = parport_read_status (port);
> + status = parport_read_status(port);
> if ((status & mask) == result)
> return 0;
>
> @@ -224,7 +224,7 @@ int parport_wait_peripheral(struct parport *port,
>
> #ifdef CONFIG_PARPORT_1284
> /* Terminate a negotiated mode. */
> -static void parport_ieee1284_terminate (struct parport *port)
> +static void parport_ieee1284_terminate(struct parport *port)
> {
> int r;
> port = port->physport;
> @@ -237,11 +237,11 @@ static void parport_ieee1284_terminate (struct parport *port)
> /* Terminate from EPP mode. */
>
> /* Event 68: Set nInit low */
> - parport_frob_control (port, PARPORT_CONTROL_INIT, 0);
> - udelay (50);
> + parport_frob_control(port, PARPORT_CONTROL_INIT, 0);
> + udelay(50);
>
> /* Event 69: Set nInit high, nSelectIn low */
> - parport_frob_control (port,
> + parport_frob_control(port,
> PARPORT_CONTROL_SELECT
> | PARPORT_CONTROL_INIT,
> PARPORT_CONTROL_SELECT

Now, the alignment is lost and a new checkpatch error is introduced.

--
Regards
Sudip

\
 
 \ /
  Last update: 2017-08-07 22:50    [W:0.203 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site