lkml.org 
[lkml]   [2017]   [Aug]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/5] parport: add newline to trailing statements
Hi,

On Mon, Jul 17, 2017 at 05:36:58PM +0100, Carlos Palminha wrote:
> based on checkpatch, add newline to trailing statements
>
> Signed-off-by: Carlos Palminha <palminha@synopsys.com>
> ---
> drivers/parport/daisy.c | 7 +++++--
> drivers/parport/ieee1284.c | 17 +++++++++--------
> drivers/parport/ieee1284_ops.c | 8 ++++++--
> drivers/parport/parport_cs.c | 4 +++-
> drivers/parport/parport_gsc.c | 6 ++++--
> drivers/parport/probe.c | 4 +++-
> 6 files changed, 30 insertions(+), 16 deletions(-)

<snip>

> goto try_again;
> success:
> parport_frob_control (port, PARPORT_CONTROL_STROBE, 0);
> diff --git a/drivers/parport/parport_cs.c b/drivers/parport/parport_cs.c
> index e9b52e4a4648..993565fef73b 100644
> --- a/drivers/parport/parport_cs.c
> +++ b/drivers/parport/parport_cs.c
> @@ -88,7 +88,9 @@ static int parport_probe(struct pcmcia_device *link)
>
> /* Create new parport device */
> info = kzalloc(sizeof(*info), GFP_KERNEL);
> - if (!info) return -ENOMEM;
> + if (!info)
> + return -ENOMEM;

Please use tab to indent the code. I know some part of this file uses
4 spaces to indent, so if you use one tab before 'return -ENOMEM', it
will look perfect.


--
Regards
Sudip

\
 
 \ /
  Last update: 2017-08-07 22:43    [W:0.077 / U:0.532 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site