lkml.org 
[lkml]   [2017]   [Aug]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: block/ps3vram: Delete an error message for a failed memory allocation in ps3vram_cache_init()
From
Date
On 08/07/2017 09:27 AM, SF Markus Elfring wrote:
>>> Omit an extra message for a memory allocation failure in this function.
>>>
>>> This issue was detected by using the Coccinelle software.
>>
>> NACK
>>
>> When a user asks me for help I would certainly like to get
>> 'Could not allocate cache tags' as apposed to nothing,
>
> Do you find the default allocation failure report insufficient?

The default is OK. I didn't consider one would be triggered by
the kzalloc failure.

>> since the return value of ps3vram_cache_init() is not checked.
>
> Are there any more update candidates to consider for better exception handling?

The return of ps3vram_cache_init() should be checked. Feel
free to propose others.

-Geoff

\
 
 \ /
  Last update: 2017-08-07 20:28    [W:0.124 / U:0.656 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site