lkml.org 
[lkml]   [2017]   [Aug]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 4.4 17/91] drm: rcar-du: Simplify and fix probe error handling
    From
    Date
    On Fri, 2017-08-04 at 16:15 -0700, Greg Kroah-Hartman wrote:
    [...]
    > @@ -291,6 +290,15 @@ static int rcar_du_probe(struct platform
    > rcdu->dev = &pdev->dev;
    > rcdu->info = of_match_device(rcar_du_of_table, rcdu->dev)->data;
    >
    > + platform_set_drvdata(pdev, rcdu);
    > +
    > + /* I/O resources */
    > + mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
    > + rcdu->mmio = devm_ioremap_resource(&pdev->dev, mem);
    > + if (IS_ERR(rcdu->mmio))
    > + ret = PTR_ERR(rcdu->mmio);
    [...]

    Last line above should be:

    return PTR_ERR(rcdu->mmio);

    This is an error introduced in the backport, not the upstream commit.

    Ben.

    --
    Ben Hutchings
    Software Developer, Codethink Ltd.


    \
     
     \ /
      Last update: 2017-08-07 17:19    [W:5.359 / U:0.596 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site