Messages in this thread |  | | From | Andy Lutomirski <> | Date | Sun, 6 Aug 2017 08:43:46 -0700 | Subject | Re: [PATCH v1] platform/x86: wmi: Switch to use new generic UUID API |
| |
On Fri, Aug 4, 2017 at 8:27 AM, Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > On Fri, Aug 4, 2017 at 6:01 PM, Andy Lutomirski <luto@kernel.org> wrote: >>> On Aug 2, 2017, at 9:28 AM, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: >>> >>> There are new types and helpers that are supposed to be used in new code. >>> >>> As a preparation to get rid of legacy types and API functions do >>> the conversion here. >>> >>> While here, update Copyright to reflect this change along with previous >>> one for the topic. > >>> struct guid_block { >>> - char guid[16]; >>> + guid_t guid; >> >> NAK. guid_block is a firmware interface, so opaque kernel types don't >> belong in it. > > I f we leave this, what do you think about everything else?
Assuming it works, it's fine with me. I'd be happy to test.
Keep in mind that this beast is a *little-endian* GUID abomination, and I don't see generic conversion helpers. Something might need to be added.
--Andy
|  |