[lkml]   [2017]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 13/14] vme: tsi148: Improve 17 size determinations
On 26 August 2017 at 08:00, SF Markus Elfring
<> wrote:
>>> @@ -2363,5 +2364,5 @@ static int tsi148_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>>> master_num--;
>>> tsi148_device->flush_image =
>>> - kmalloc(sizeof(struct vme_master_resource), GFP_KERNEL);
>>> + kmalloc(sizeof(*tsi148_device->flush_image), GFP_KERNEL);
>> This line is now a tiny bit too long
> Can you eventually tolerate a line length of 81 characters at such a source code place?

I think there's some irony here. On the one hand you are submitting
patches that correct coding style issues, on the other you are asking
whether we can ignore the coding style...

>> and needs to be broken over two lines.
> How would like to achieve this?
> * It seems that you would not like to perform such a tweak yourself.

To be honest, it is quicker and easier in this instance to do just
that. So that's now done.

Patches now in my testing branch:

For future reference:

> * Do you expect a resend for the complete patch series?

Unless the maintainer has commented that they have accepted patches x,
y and z, then sending the entire series again is generally the right
thing to do.

> * Will it be sufficient to send another patch only for the requested reformatting
> of a single line?

No, unless the patches have been accepted as-is.


 \ /
  Last update: 2017-08-30 21:49    [W:0.091 / U:1.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site