Messages in this thread |  | | Date | Tue, 29 Aug 2017 20:22:54 -0700 | From | Guenter Roeck <> | Subject | Re: watchdog: sc1200: constify pnp_device_id |
| |
On Wed, Aug 16, 2017 at 10:27:03AM +0530, Arvind Yadav wrote: > pnp_device_id are not supposed to change at runtime. All functions > working with pnp_device_id provided by <linux/pnp.h> work with > const pnp_device_id. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> --- > drivers/watchdog/sc1200wdt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/watchdog/sc1200wdt.c b/drivers/watchdog/sc1200wdt.c > index b34d3d5..8e4e2fc 100644 > --- a/drivers/watchdog/sc1200wdt.c > +++ b/drivers/watchdog/sc1200wdt.c > @@ -342,7 +342,7 @@ static int __init sc1200wdt_probe(void) > > #if defined CONFIG_PNP > > -static struct pnp_device_id scl200wdt_pnp_devices[] = { > +static const struct pnp_device_id scl200wdt_pnp_devices[] = { > /* National Semiconductor PC87307/PC97307 watchdog component */ > {.id = "NSC0800", .driver_data = 0}, > {.id = ""},
|  |