Messages in this thread Patch in this message |  | | Date | Tue, 29 Aug 2017 14:21:33 -0700 | From | tip-bot for Jiri Olsa <> | Subject | [tip:perf/core] perf values: Fix allocation check |
| |
Commit-ID: f4ef3b7c184c4c269f953f226f7158347d007622 Gitweb: http://git.kernel.org/tip/f4ef3b7c184c4c269f953f226f7158347d007622 Author: Jiri Olsa <jolsa@kernel.org> AuthorDate: Thu, 24 Aug 2017 18:27:34 +0200 Committer: Arnaldo Carvalho de Melo <acme@redhat.com> CommitDate: Mon, 28 Aug 2017 16:44:43 -0300
perf values: Fix allocation check
Bailing out in case the allocation failed, not the other way round.
Signed-off-by: Jiri Olsa <jolsa@kernel.org> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> Cc: Andi Kleen <andi@firstfloor.org> Cc: David Ahern <dsahern@gmail.com> Cc: Mark Rutland <mark.rutland@arm.com> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Link: http://lkml.kernel.org/r/20170824162737.7813-8-jolsa@kernel.org Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> --- tools/perf/util/values.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/values.c b/tools/perf/util/values.c index 9ac36bf..2c4af02 100644 --- a/tools/perf/util/values.c +++ b/tools/perf/util/values.c @@ -131,7 +131,7 @@ static int perf_read_values__enlarge_counters(struct perf_read_values *values) for (i = 0; i < values->threads; i++) { u64 *value = realloc(values->value[i], counters_max * sizeof(**values->value)); - if (value) { + if (!value) { pr_debug("failed to enlarge read_values ->values array"); goto out_free_name; }
|  |