Messages in this thread Patch in this message |  | | Date | Tue, 29 Aug 2017 14:21:07 -0700 | From | tip-bot for Jiri Olsa <> | Subject | [tip:perf/core] perf values: Fix thread index bug |
| |
Commit-ID: 64eed1deb6d87f4c0efe03297f50367a3689eb56 Gitweb: http://git.kernel.org/tip/64eed1deb6d87f4c0efe03297f50367a3689eb56 Author: Jiri Olsa <jolsa@kernel.org> AuthorDate: Thu, 24 Aug 2017 18:27:33 +0200 Committer: Arnaldo Carvalho de Melo <acme@redhat.com> CommitDate: Mon, 28 Aug 2017 16:44:42 -0300
perf values: Fix thread index bug
We are taking wrong index (+1) for first thread, which leaves thread with index 0 unused and uninitialized.
Signed-off-by: Jiri Olsa <jolsa@kernel.org> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> Cc: Andi Kleen <andi@firstfloor.org> Cc: David Ahern <dsahern@gmail.com> Cc: Mark Rutland <mark.rutland@arm.com> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Link: http://lkml.kernel.org/r/20170824162737.7813-7-jolsa@kernel.org Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> --- tools/perf/util/values.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util/values.c b/tools/perf/util/values.c index 5de2e15..9ac36bf 100644 --- a/tools/perf/util/values.c +++ b/tools/perf/util/values.c @@ -98,7 +98,7 @@ static int perf_read_values__findnew_thread(struct perf_read_values *values, return i; } - i = values->threads + 1; + i = values->threads; values->value[i] = malloc(values->counters_max * sizeof(**values->value)); if (!values->value[i]) { pr_debug("failed to allocate read_values counters array"); @@ -106,7 +106,7 @@ static int perf_read_values__findnew_thread(struct perf_read_values *values, } values->pid[i] = pid; values->tid[i] = tid; - values->threads = i; + values->threads = i + 1; return i; }
|  |