lkml.org 
[lkml]   [2017]   [Aug]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v6 4/4] perf vendor events arm64: Add ThunderX2 implementation defined pmu core events
Shaokun,

On 29.08.17 17:26:00, Zhangshaokun wrote:
> On 2017/8/24 20:03, Ganapatrao Kulkarni wrote:
> > This is not a full event list, but a short list of useful events.
> >
> > Signed-off-by: Ganapatrao Kulkarni <ganapatrao.kulkarni@cavium.com>
> > ---
> > tools/perf/pmu-events/arch/arm64/mapfile.csv | 15 ++++++
> > .../arm64/thunderx2/implementation-defined.json | 62 ++++++++++++++++++++++
> > 2 files changed, 77 insertions(+)
> > create mode 100644 tools/perf/pmu-events/arch/arm64/mapfile.csv
> > create mode 100644 tools/perf/pmu-events/arch/arm64/thunderx2/implementation-defined.json
> >
>
> I saw you also used thunderx2 in tools/perf/pmu-events/arch/arm64/, how about John's suggestion
> that would use vendor sub-folder?
> Of course, appreciate maintainer's comments.

this would just add another level of subdirectories. I rather would
prefer to have a per platform dir comparable to what is listed in

arch/arm64/Kconfig.platforms

This is the same as Ganapat has implemented it.

-Robert

\
 
 \ /
  Last update: 2017-08-29 14:49    [W:0.152 / U:1.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site