Messages in this thread |  | | Date | Fri, 25 Aug 2017 13:39:14 +0900 | From | Byungchul Park <> | Subject | Re: [PATCH 4/4] lockdep: Fix workqueue crossrelease annotation |
| |
On Thu, Aug 24, 2017 at 04:02:40PM +0200, Peter Zijlstra wrote: > > > + if (c == XHLOCK_PROC) {
I found this now. Are you trying to invalidate it w/o checking force? No, we _should not_ do this. It's worse than work-around code.
No reason to do this here. Please communicate with me more or understand how this code works before applying it.
> > > + /* verified the former, ensure the latter */ > > > + WARN_ON_ONCE(!force && cur->lockdep_depth); > > > + invalidate_xhlock(&xhlock(cur->xhlock_idx)); > > > }
|  |